Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

call user_name method instead of git_user_name method #78

Merged
merged 1 commit into from
Jun 26, 2019

Conversation

schadenfred
Copy link
Contributor

@schadenfred schadenfred commented Jan 2, 2019

If the user has not configured git with a github user, the following command:

$ gem bootstrap 

...yields the following error:

Scaffolding gem getsome
ERROR:  While executing gem ... (NameError)
    undefined local variable or method `git_user_name' for #<Gem::Release::Context::Git:0x000055eabe5b5a00>

Gem author's intent appears to have been to call the user_name method defined in line 17 above instead of git_user_name, so I changed the code to reflect that intent. Did not test.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.413% when pulling dd33d16 on schadenfred:master into f4c8e56 on svenfuchs:master.

@pboling
Copy link
Contributor

pboling commented Jun 25, 2019

Ping @svenfuchs this looks safe, corrects an apparent typo.

@PikachuEXE PikachuEXE merged commit e6bf4a9 into svenfuchs:master Jun 26, 2019
@PikachuEXE
Copy link
Collaborator

Thanks for submitting the request
I don't have perm to release the gem now though :P

@PikachuEXE
Copy link
Collaborator

Fix released as 2.0.2, go get it! 🚢

@PikachuEXE
Copy link
Collaborator

Test result:
image

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants