Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix bump command to show bumped version for tag & release messages #83

Merged
merged 1 commit into from
Jul 4, 2019

Conversation

PikachuEXE
Copy link
Collaborator

#79 related but incomplete fix

After patch:
image
Before patch:
image

To use correct file name for built gem in pretend mode (it's already correct in actual run)
A big change seems to be required since the file name is read through:

And the scale of change required to fix a small pretend mode only issue seems too large for me
Also the filename doesn't matter anyway (Let me know if I am wrong)
If you have better idea let me know (or just submit a PR)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 96.423% when pulling 40ef67f on fix/post-bump-message into f5776ff on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 96.423% when pulling 40ef67f on fix/post-bump-message into f5776ff on master.

@PikachuEXE PikachuEXE merged commit 5c6784a into master Jul 4, 2019
@PikachuEXE PikachuEXE deleted the fix/post-bump-message branch July 4, 2019 02:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants