Ensure git index is refreshed before clean? check

[tomgi]

Hi,

I've encountered a problem with gem bump telling me that Uncommitted changes found. Please commit or stash. Aborting. in cases where I didn't have any uncommitted changes (and git status or git diff would agree with me on that ;)).

After doing some investigation I discovered that the underlying reason is a combination of a few things:

1. I run my local gem development inside a docker container, with the entire gem working directory mapped as a volume inside the container
2. git diff-index is lazy by default, i.e. it considers files to be different when the modification time differs (even when the actual content doesn't)
3. The timezone inside of my docker container is different than my host timezone

As a result, git diff-index run inside of my docker container considers all files to be modified, which stops gem bump from doing its thing.

I found this git update-index --refresh command as a suggested solution to very similar problems described in

• http://git.661346.n2.nabble.com/BUG-in-git-diff-index-td7652105.html
• https://stackoverflow.com/questions/34807971/why-does-git-diff-index-head-result-change-for-touched-files-after-git-diff-or-g

Thanks!

[coveralls]

Coverage remained the same at 93.945% when pulling 7ce015d on tomgi:patch-1 into 7038416 on svenfuchs:master.

[PikachuEXE]

There is a comment suggesting
git update-index -q --really-refresh instead of
git update-index --refresh
What do you think?

[tomgi]

Hey @PikachuEXE, to be fair I don't really understand the difference between --refresh and --really-refresh.

They both solve the problem in my case, but I guess there might be some other scenarios where only --really-refresh would do the trick.

I'll update the PR to do --really-refresh just to be extra safe, thanks for the suggestion!

[PikachuEXE]

For some reason I can't release a new version via gem release --tag --push since it keep using the old version number
Strange~

[PikachuEXE]

OK resolved via adding bundle exec prefix:
bundle exec gem release --tag --push
Anyway it's released now