Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Journey parameters #86

Closed
wants to merge 3 commits into from
Closed

Journey parameters #86

wants to merge 3 commits into from

Conversation

anitagraham
Copy link

Running with Rails 7.1.3 and testing an active storage route I have been getting

   NoMethodError:
       undefined method `merge' for nil:NilClass
     # ./vendor/cache/ruby/3.2.0/gems/routing-filter-0.7.0/lib/routing_filter/adapters/routers/journey.rb:13:in `block in find_routes'
     # ./vendor/cache/ruby/3.2.0/gems/routing-filter-0.7.0/lib/routing_filter/adapters/routers/journey.rb:11:in `map'
     # ./vendor/cache/ruby/3.2.0/gems/routing-filter-0.7.0/lib/routing_filter/adapters/routers/journey.rb:11:in `find_routes'

Adding a default value of {} to parameters fixed this

@anitagraham
Set default for 'parameters' {} to avoid
d8add16 
 undefined method `merge' for nil:NilClass
@anitagraham
Revert "Set default for 'parameters' {} to avoid"
9918a01 
This reverts commit d8add16.
@anitagraham
Set default for 'parameters' {} to avoid
090a720 
 undefined method `merge' for nil:NilClass
@fwolfst fwolfst mentioned this pull request Feb 22, 2024
Open
@johnnyshields
Copy link

This PR should be closed in favor of #87

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anitagraham @johnnyshields