chore: replaces c8 with node native coverage #46
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
c8 in our setup always returned 100% coverage for all things - which might have to do with an issue in tsx (see tsx #433 ), but might just as well be caused by something unexpectedly breaking in de nodejs / v8 w.r.t. loader coverage.
--experimental-test-coverage
is not perfect either (i.c.w. tsx it's unstable on node > 20.12.2, and line numbers are off), but at least the coverage data we get is more realistic.How Has This Been Tested?
Screenshots
Types of changes
Checklist
📖
⚖️