node or new #1219
Merged
node or new #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
just reset the package lock to the old state and commit it again :) |
Fuzzyma
reviewed
Sep 22, 2021
|
I'm a bit new to using git so sorry if some of the things that I did seem a bit strange. Anyway I think that now the only difference in this branch is in the function nodeOrNew |
|
No problem. I can just squash everything into one commit so nobody sees all the commits |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
edit nodeornew in order to behave consistently across different contexts.
note. npm automatically updated the package lock file and I pushed it without realizing so it would probably not be desired to merge that.