Add node document-fragment type check #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This sounds useful. Can you give me one concrete piece of sample code? |
Yes, we are using svg.js in polymer 2 and we successfully reproduced this issue in this jsfiddle: |
|
Mh when i load this page I just get an "Polymer is undefined" error |
Try in Chrome please. It works for me. |
|
Ok, forgot to ask. Can you add tests? |
|
I opened a new PR for the unit tests please check it. Also we would like ask you to make a patch release with this fix as soon as possible please. Thank you! |
Fuzzyma
added a commit
that referenced
this pull request
Nov 13, 2018
### Fixed - fixed calling `parent()` on `documentFragment`s children (#927) - parser is not focusable anymore (#908) - `SVG.Element.click(null)` correctly unbinds the event (#878) - fix memory leak (#905) ### Added - `SVG.Set` now accepts another Set as input (#893) - `on()/off()` accepts multiple event names as input (backport from 3.0)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It solves the
node.getAttribute is not a functionissue in Shadow DOM.