Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[JavaJaxRS] Fix parameter annotation generation #564

Merged

Conversation

michaeldavis-wf
Copy link
Contributor

When generating parameter annotations with the JavaJaxRS generator, those annotations are invalid and cause compilation errors. Currently, any non-cookie parameter is generated as such:

public Response listUsers(@Parameter(ParameterIn.HEADER, description = "Http Authorization Header" ,required=true) @HeaderParam("Authorization"))

Which throws a compilation error:

annotation values must be of the form 'name=value'

This appears to be a bug introduced recently.

This now generates as such, which compiles correctly:

public Response listUsers(@Parameter(in = ParameterIn.HEADER, description = "Http Authorization Header" ,required=true) @HeaderParam("Authorization"))

@HugoMario
Copy link
Contributor

thanks a lot @michaeldavis-wf!!! for this PR

@HugoMario HugoMario merged commit 805527d into swagger-api:master Dec 19, 2019
@michaeldavis-wf michaeldavis-wf deleted the oa3-api-parameter-templates branch December 19, 2019 14:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants