Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix #12431 - [CSHARP] update testFolder when setting sourceFolder #12432

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ruimaciel
Copy link

@ruimaciel ruimaciel commented Jul 28, 2024

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

This PR fixes #12431 by updating the C# code generator to set testFolder when sourceFolder is updated, thus preventing test packages from being inadvertently stored in the original/default sourceFolder.

Here's a summary of the changes:

  • adds unit tests reproducing the problem,
  • sets testFolder when sourceFolder is set.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CSHARP] test project is generated in default sourceFolder even when sourceFolder is set
1 participant