Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(swagger-codegen): use Ubuntu-based JRE image #12514

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fgreinacher
Copy link
Contributor

@fgreinacher fgreinacher commented Jan 8, 2025

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

The Alpine JRE image introduced in #12470 only supports ARM64 which breaks the Docker workflow, see https://github.com/swagger-api/swagger-codegen/actions/runs/12389035407/job/34581266257.

The default Ubuntu image supports all relevant architectures.

BREAKING CHANGE: This drops support for IBM z Systems (linux/s390x).

The Alpine JRE image only supports ARM64. The Ubuntu image supports all relevant architectures.

BREAKING CHANGE: This drops support for IBM z Systems (linux/s390x).
@fgreinacher
Copy link
Contributor Author

@frantuma Can you have one more look please? 🙇

@fgreinacher
Copy link
Contributor Author

@frantuma Let me know if I can somehow help with reviewing/testing this 🙇

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant