Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add option modelPropertyNaming to javascript generator #8086

Merged
merged 1 commit into from
May 25, 2018
Merged

Add option modelPropertyNaming to javascript generator #8086

merged 1 commit into from
May 25, 2018

Conversation

stianlik
Copy link
Contributor

@stianlik stianlik commented Apr 27, 2018

Fixes 6530.

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. not relevant for this change — did not commit petstore sample
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Add option modelPropertyNaming to JavascriptClientCodegen to support different naming conventions for properties. See issue #6530

@CodeNinjai @frol @cliffano

@frol
Copy link
Contributor

frol commented Apr 27, 2018

LGTM! Well done!

@stianlik
Copy link
Contributor Author

@frol is there anything else I need to do to get this merged?

@frol
Copy link
Contributor

frol commented May 25, 2018

I have no permissions to merge it, but it looks good to me.

@HugoMario
Copy link
Contributor

thanks @stianlik !!
I reviewed the CI's error but they don't seem to be related to these changes.

@i-tabu
Copy link

i-tabu commented Feb 6, 2021

Great work! Thanks

This was referenced Mar 11, 2021
This was referenced Mar 11, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants