-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Consider java.time.OffsetDateTime a Swagger DateTime primitive #1759
Conversation
@fehguy why hasn't this been merged yet? |
Because there's too much to do :) I don't just merge without testing, and I should get to this shortly. Perhaps @frantuma can review faster than me. |
Good to know, I already feared there might be valid reasons to refuse it. It's really strange how the swagger online editor and cli generate Java8 time types, but the swagger UI doesn't properly support it... |
@Hades32 doesn't support it how? |
@webron it's not shown as a timestamp but instead a large json object with many fields. so pretty useless... |
@webron I don't see why we wouldn't do this--but we do need to add some tests before merging, or it'll get lost. |
All I was asking is how this is seen in swagger-ui as some people expect it to be something other than a string. It definitely shouldn't appear as a multi-field object. |
+1 for this PR |
@webron This is how it renders... |
+1 for this |
+1 |
No description provided.