Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix errors in embedded sourcemaps #900

Merged
merged 2 commits into from
Nov 22, 2016

Conversation

richvdh
Copy link
Contributor

@richvdh richvdh commented Nov 21, 2016

The sourcemaps in the browserified libraries were incorrect due to the addition
of the header. We can fix this using gulp-sourcemaps to export correct
sourcemaps.

The sourcemaps in the browserified libraries were incorrect due to the addition
of the header. We can fix this using gulp-sourcemaps to export correct
sourcemaps.
@fehguy
Copy link
Contributor

fehguy commented Nov 22, 2016

@richvdh looks like the build doesn't like es6 syntax. Can you address and update the PR?

Gulp-sourcemaps 2.x requires node 4 or later, so pin to 1.x to maintain
compatibility with 0.10.
@richvdh
Copy link
Contributor Author

richvdh commented Nov 22, 2016

Thanks for the feedback: looks like a dependency of gulp-sourcemaps (strip-bom) is using the arrow notation.

For now I've pinned gulp-sourcemaps to 1.x, which claims compatibility with node 0.10. Obviously an alternative would be to bump the version of node requested by travis.yml: 0.10 is pretty old these days [1].

[1] https://github.com/nodejs/LTS#lts-schedule

@fehguy fehguy merged commit 95cc9f2 into swagger-api:master Nov 22, 2016
@fehguy fehguy modified the milestone: v2.1.24 Nov 23, 2016
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants