-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
missing host still not working #2904
Comments
I see slightly different behavior with 3.0.5. The good news is that it works for me, even with HTTPS. The only issue that I see is that the displayed curl command is wrong. You can try it out yourself here: https://beta.prd.yona.nu/swagger-ui/index.html. If you just take the first operation and provide a nonsense user ID and password, you'll get an error, which indicates that request properly reaches the server. The curl command is wrong:
That should have been:
So: HTTPS and the right host name. The Swagger spec is referenced as |
Scheme problem is fixed: if no scheme is defined in the spec, we will try to extract a valid scheme from the URL the spec is loaded from (doesn't affect relative-path spec URLs) before falling back to For the second part, looks like |
Found it- fix incoming. |
thanks, now it works for me 👍 |
The curl command is now right but unfortunately HTTPS doesn't work anymore. I've logged #2919 for this. |
This should have been addressed but as of now, I'm not seeing proper behavior.
Using this URL against the petstore, which is latest master:
http://petstore.swagger.io/?url=https://generator.swagger.io/api/swagger.json
I see two issues.
First, the CURL url is incorrect. Note the protocol should be
https
:Next, the request never actually succeeds. Note the URL in the network console:
The text was updated successfully, but these errors were encountered: