-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Petstore no longer honouring explicit HTTPS scheme, and using HTTP instead? #2906
Comments
Seems related to #2904. |
Latest master doesn't exhibit this problem (very likely that #2927 fixed it). Getting a CORS error with this spec:
We're requesting with @alzadude, this will be included in our Friday release. If you see any lingering problems, please reply here and I'll look into it. Closing! |
Hi @shockey Looking forward to today's release with this fix :) Would you be able to let me know when the release is done so I can check and test? Thanks :) |
@alzadude If you 'watch' the project, you'll get notifications on releases as well (though you'll also get ticket notifications too). In general we try to make releases every Friday, so you can check tomorrow. |
Ok @webron thanks :) |
@alzadude, I'll do my best to ping you, but releases generally happen at 6PM Pacific time 👍 |
Hi @shockey, I just tried again but I'm still getting the same Thanks :) |
@alzadude, we did release on Friday, my apologies for not pinging you here. It works for me here: http://petstore.swagger.io/?url=https://imin-platform-api.imin.co/v1/swagger.json Could you empty your caches and give it another try? |
Hi @shockey it seems to be working now :) with one exception: When I add an an api key authorization header, even though the curl output shows HTTPS, I still get I am wondering if this is the same issue, or a new issue? Thanks :) |
@alzadude can you share a spec to reproduce? |
swagger 3.0 error
|
Starting the container as follow
The |
Solving it by enabling CORS on the aiohttp server side (using aiohttp_cors)
|
From @alzadude on April 11, 2017 13:37
A recent change to the Petstore seems to have broken the explicit HTTPS api call behaviour.
Steps to reproduce:
https://imin-platform-api.imin.co/v1/swagger.json
)HTTPS
GET
/v1/search/sessions
)Execute
Expected:
Petstore executes api call using HTTPS as specified.
Actual:
Petstore appears to execute api call using HTTP (which for our api, doesn't work unfortunately), and Swagger then shows
TypeError: NetworkError when attempting to fetch resource.
Would someone be able to investigate this issue to determine why making the HTTPS scheme explicit isn't working, and why HTTP is being used instead?
Thanks :)
Copied from original issue: swagger-api/swagger-core#2171
The text was updated successfully, but these errors were encountered: