Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Regex issue in docker-run.sh for VALIDATOR_URL #2936

Closed
redsux opened this issue Apr 20, 2017 · 2 comments
Closed

Regex issue in docker-run.sh for VALIDATOR_URL #2936

redsux opened this issue Apr 20, 2017 · 2 comments
Labels
locked-by: lock-bot type: bug version: 3.x

Comments

@redsux
Copy link
Contributor

redsux commented Apr 20, 2017

Hello,

I just tried to set VALIDATOR_URL when running your container and it appears that docker-run.sh don't match your regex line 42 sed -i "s|\(url: url,.*\).

There is a useless "url" string, a little fix : sed -i "s|\(url: .*,\)

Rergards,
Red
@fehguy
Copy link
Contributor

fehguy commented Apr 20, 2017

@redsux please send a pr and we'll get it merged

@redsux
Copy link
Contributor Author

redsux commented Apr 21, 2017

@fehguy : Done, pr #2950

fehguy added a commit that referenced this issue Apr 21, 2017
@fehguy
Merge pull request #2950 from redsux/issue-2936
a6a0299 
Fix issue #2936 : docker and VALIDATOR_URL variable
@shockey shockey closed this as completed Feb 8, 2018
@lock lock bot locked and limited conversation to collaborators Jul 2, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
locked-by: lock-bot type: bug version: 3.x
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@webron @fehguy @redsux @shockey