Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

SwaggerUI@5.4.1 - corrupted exports for swagger-ui-react #9143

Closed
char0n opened this issue Aug 17, 2023 · 3 comments
Closed

SwaggerUI@5.4.1 - corrupted exports for swagger-ui-react #9143

char0n opened this issue Aug 17, 2023 · 3 comments
Assignees
@char0n
Labels
type: regression version: 5.x

Comments

@char0n
Copy link
Member

char0n commented Aug 17, 2023 •
edited
Loading

swagger-ui-react tries to reuse the package.json of swagger-ui. That is no longer possible as of 78f6ffb. exports fields of the package is pointing to files that doesn't exist in swagger-ui-react npm package. This will cause runtime errors when trying to import swagger-ui-react.
@char0n char0n self-assigned this Aug 17, 2023
@awanlin awanlin mentioned this issue Aug 17, 2023
Closed
2 tasks
@char0n char0n mentioned this issue Aug 17, 2023
Merged
char0n added a commit that referenced this issue Aug 17, 2023
@char0n
fix(swagger-ui-react): fix corrupted exports field from package.json
f2c1432 
Refs #9143
@char0n
Copy link
Member Author

char0n commented Aug 17, 2023

Addressed in #9144

char0n added a commit that referenced this issue Aug 17, 2023
@char0n
fix(swagger-ui-react): fix corrupted exports field from package.json (#…
6aa1b44 
…9144)

Refs #9143
@char0n
Copy link
Member Author

char0n commented Aug 17, 2023 •
edited
Loading

I've used imports field, which is supported by Node.js since v14.6.0 and v12.19.0. All of the major bundlers like webpack, esbuild, rollup, vite, etc... support the imports field. We'll see if there are going to be issues created considering this to be regression of EOL versions of Node.js or some minor bundler libraries.

@char0n
Copy link
Member Author

char0n commented Aug 17, 2023

Released as https://github.com/swagger-api/swagger-ui/releases/tag/v5.4.2

@char0n char0n closed this as completed Aug 17, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@char0n char0n

Labels
type: regression version: 5.x
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@char0n