Make the oauth2 scope checkbox id more unique. #2949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefangr
changed the title
|
@stefangr thanks for contribution. Could you please update branch to latest master and I'll merge |
bodnia
approved these changes
May 4, 2017
If the swagger.json defines more than one oauth2 Security scheme with matching scopes, the id of the scope checkboxes were not unique. As a result the scope for a second security scheme could not be selected. By adding the security scheme name to the id, it becomes more unique.
stefangr
force-pushed
the
fix_oauth2_scope_checkbox_uniqueness
branch
from
c7de172 to
073eff4
Compare
|
@bodnia The branch is updated. |
|
@stefangr thank you for your cooperation! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the swagger.json defines more than one oauth2 Security scheme with
matching scopes, the id of the scope checkboxes were not unique.
As a result the scope for a second security scheme could not be
selected.
By adding the security scheme name to the id, it becomes more unique.