Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Render Markdown for object and property descriptions #3236

Merged
merged 4 commits into from
Jun 17, 2017
Merged

Render Markdown for object and property descriptions #3236

merged 4 commits into from
Jun 17, 2017

Conversation

mhw
Copy link
Contributor

@mhw mhw commented Jun 13, 2017

This adds Markdown rendering for object and property descriptions. With this addition I think all the cases mentioned in #2745 have been addressed.

@webron webron requested a review from shockey June 13, 2017 17:28
@webron
Copy link
Contributor

webron commented Jun 13, 2017

@shockey please review and remember... sanitization.

@shockey
Copy link
Contributor

shockey commented Jun 13, 2017

@webron This PR uses the sanitized Markdown interface created in #3165. I'll make sure to double-check for any security issues.

shockey
shockey approved these changes Jun 17, 2017
View reviewed changes
Copy link
Contributor

@shockey shockey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested for functionality, and for security against our Evil Swagger definitions.

@shockey shockey merged commit eccc26d into swagger-api:master Jun 17, 2017
@shockey
Copy link
Contributor

shockey commented Jun 17, 2017

Thanks @mhw! We appreciate the improvement 😄

@mhw mhw deleted the fix-model-markdown branch June 20, 2017 13:11
@mhw mhw mentioned this pull request Aug 7, 2017
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@shockey shockey shockey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhw @webron @shockey