Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix phpdoc for JsonSchena::setType() #154

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Conversation

simivar
Copy link
Contributor

@simivar simivar commented Sep 8, 2023

The type definition in setType method can be updated as the property itself accepts string too

The type definition in `setType` method can be updated as the property itself accepts `string` too
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #154 (447303e) into master (2d7b8e2) will not change coverage.
The diff coverage is n/a.

❗ Current head 447303e differs from pull request most recent head ac6bfe9. Consider uploading reports for the commit ac6bfe9 to get more accurate results

@@           Coverage Diff           @@
##           master     #154   +/-   ##
=======================================
  Coverage   92.64%   92.64%           
=======================================
  Files          27       27           
  Lines        1687     1687           
=======================================
  Hits         1563     1563           
  Misses        124      124           
Files Changed Coverage Δ
src/JsonSchema.php 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vearutop vearutop merged commit d23adb5 into swaggest:master Sep 12, 2023
@vearutop
Copy link
Member

Thank you!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants