Fix text scale and enable glyph position rounding again #8429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nefsen402
force-pushed
the
fix-text-scale
branch
from
a602fb3
to
878ed3d
Compare
Nefsen402
force-pushed
the
fix-text-scale
branch
from
878ed3d
to
1f765b8
Compare
Comment on lines
+177
to
+186
| cairo_set_antialias(c, CAIRO_ANTIALIAS_BEST); | ||
| for (int i = 0; i < root->outputs->length; ++i) { | ||
| struct sway_output *output = root->outputs->items[i]; | ||
| if (!output->wlr_output->enabled) { | ||
| continue; | ||
| } | ||
|
|
||
| int size, baseline; | ||
| get_text_size(c, config->font_description, &size, NULL, | ||
| &baseline, output->wlr_output->scale, props->pango_markup, "%s", buffer->text); |
There was a problem hiding this comment.
I wonder if it would be fine to just take the largest scale from all outputs.
get_text_size is quite expensive - a quick test on my Ryzen laptop on battery power clocks get_text_size with a random title around 400µs, although it gets a lot faster on external power of course.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8421