Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(swc_allocator): Remove nightly from default feature #10058

Merged
merged 6 commits into from
Feb 20, 2025

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 20, 2025

Description:

It disturbs moving some types to arena allocator

@kdy1 kdy1 self-assigned this Feb 20, 2025
@kdy1 kdy1 added this to the Planned milestone Feb 20, 2025
Copy link

changeset-bot bot commented Feb 20, 2025

🦋 Changeset detected

Latest commit: 00d0ded

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 marked this pull request as ready for review February 20, 2025 05:25
@kdy1 kdy1 requested a review from a team as a code owner February 20, 2025 05:25
kodiakhq[bot]
kodiakhq bot previously approved these changes Feb 20, 2025
@kdy1 kdy1 enabled auto-merge (squash) February 20, 2025 05:25
kodiakhq[bot]
kodiakhq bot previously approved these changes Feb 20, 2025
kodiakhq[bot]
kodiakhq bot previously approved these changes Feb 20, 2025
@kdy1 kdy1 disabled auto-merge February 20, 2025 05:36
@kdy1 kdy1 merged commit e78b9d1 into swc-project:main Feb 20, 2025
171 checks passed
@kdy1 kdy1 deleted the mem-min branch February 20, 2025 07:03
Copy link

codspeed-hq bot commented Feb 20, 2025

CodSpeed Performance Report

Merging #10058 will degrade performances by 4.85%

Comparing kdy1:mem-min (00d0ded) with main (c75578b)

Summary

⚡ 2 improvements
❌ 4 regressions
✅ 185 untouched benchmarks
⁉️ 5 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es/full/minify/libraries/jquery 167 ms 172.3 ms -3.08%
es/full/minify/libraries/moment 103.9 ms 109.2 ms -4.85%
⁉️ common/allocator/alloc/cached-no-scope/1000000 112.5 ms N/A N/A
⁉️ common/allocator/alloc/cached-scoped/1000000 52.4 ms N/A N/A
⁉️ common/allocator/alloc/no-scope/1000000 112.2 ms N/A N/A
⁉️ common/allocator/alloc/scoped/1000000 52.7 ms N/A N/A
⁉️ common/allocator/alloc/std/1000000 89.2 ms N/A N/A
es/codegen/large 692.7 µs 657.3 µs +5.39%
es/lints/libs/lodash 8.1 ms 8.3 ms -3.15%
es/minifier/libs/jquery 137.4 ms 131.3 ms +4.62%
es/minifier/libs/lodash 151.1 ms 157.5 ms -4.07%

@kdy1 kdy1 modified the milestones: Planned, v1.11.1 Feb 25, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant