Disable SETTINGS_ENABLE_PUSH HTTP/2 setting #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjcairo
force-pushed
the
disable-server-push
branch
from
959290c to
3c5e928
Compare
FranzBusch
reviewed
Apr 29, 2024
|
@swift-server-bot test this please |
FranzBusch
approved these changes
Apr 30, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves #737
We are currently creating H2 connections using the default NIO settings, but this means we weren't sending
SETTING_ENABLE_PUSH=0. This caused the server to push streams to the client, which messed up the stream count logic (as we were assuming only the client could create new streams), resulting in a precondition failure when releasing streams.This PR updates the settings to disable the
enablePushsetting.