Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Import new Android overlay #211

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Import new Android overlay #211

merged 1 commit into from
Jul 4, 2024

Conversation

finagolfin
Copy link
Member

This was recently added in swiftlang/swift#72161 and swiftlang/swift#72634. I've been building it with this patch on my daily Android CI since then, finagolfin/swift-android-sdk#151, and natively on Android too.

@ahoppen, should be a quick review.

@finagolfin finagolfin requested a review from bnbarham as a code owner July 3, 2024 21:06
@ahoppen
Copy link
Member

ahoppen commented Jul 3, 2024

@swift-ci Please test

Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we need @bnbarham’s review to merge.

@bnbarham bnbarham merged commit 9b2ac3a into swiftlang:main Jul 4, 2024
3 checks passed
@finagolfin finagolfin deleted the droid branch July 4, 2024 07:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants