Add a new affordance that the Python module in a dSYM #10462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So the dSYM can be told what target it has been loaded into. When lldb is loading modules, while creating a target, it will run "command script import" on any Python modules in Resources/Python in the dSYM. However, this happens WHILE the target is being created, so it is not yet in the target list. That means that these scripts can't act on the target that they a part of when they get loaded. This patch adds a new python API that lldb will call: __lldb_module_added_to_target if it is defined in the module, passing in the Target the module was being added to, so that code in these dSYM's don't have to guess. (cherry picked from commit 347c5a7)
Update the ScriptInterpreterLua::LoadScriptingModule signature after the TargetSP argument was added in llvm#133290. (cherry picked from commit 28b300d)
|
This is a cherry-pick of my original patch, plus Jonas' fix for the Lua build. |
JDevlieghere
approved these changes
Apr 9, 2025
|
@swift-ci test |
|
I have to update the static bindings. I take back everything I ever said publicly about the static bindings being a good solution for anything... |
Signed-off-by: Med Ismail Bennani <ismail@bennani.ma>
|
@swift-ci test |
|
I think I had bad luck. The Linux test passed. The Windows test just got some timeout, but not in the test that I added which is the only place the new code is currently exercised, and the MacOS test failed in TestDataFormatters.py which also has no intersection with this change. |
|
@swift-ci please test |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so the dSYM can be told what target it has been loaded into.
When lldb is loading modules, while creating a target, it will run
"command script import" on any Python modules in Resources/Python in the
dSYM. However, this happens WHILE the target is being created, so it is
not yet in the target list. That means that these scripts can't act on
the target that they a part of when they get loaded.
This patch adds a new python API that lldb will call:
if it is defined in the module, passing in the Target the module was
being added to, so that code in these dSYM's don't have to guess.