[clang][Dependency Scanning] Report What a Module Exports during Scanning (#137421) #10604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
cyndyishida
approved these changes
May 1, 2025
…ning (llvm#137421) We would like to report, for a module, which direct dependencies it exports during dependency scanning. This PR implements this reporting by augmenting `ModuleDep`'s `ClangModuleDeps` variable. `ClangModuleDeps` now contains instances of `DepInfo`, which is made of a `ModuleID` and a boolean flag that indicates if a particular dependence is exported. rdar://144794793 (cherry picked from commit ea1bfbf)
qiongsiwu
force-pushed
the
cherry_pick_144794793
branch
from
e17f9f6 to
7da77c4
Compare
artemcm
approved these changes
May 1, 2025
|
I am investigating the test failures. |
|
It seems that both the macOS and Windows runs timed out. I am triggering the test again to see what happens. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to report, for a module, which direct dependencies it exports during dependency scanning. This PR implements this reporting by augmenting
ModuleDep'sClangModuleDepsvariable.ClangModuleDepsnow contains instances ofDepInfo, which is made of aModuleIDand a boolean flag that indicates if a particular dependence is exported.rdar://144794793
(cherry picked from commit ea1bfbf)