[lldb] Stop demangling every swift symbol into strings #10841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test |
kastiglione
changed the title
adrian-prantl
approved these changes
Jun 17, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InitNameIndexesloops over symbols and builds internal indexes. For Swift symbols (of typeeSymbolTypeCode), the symbol is demangled into a node tree, and the node tree is used to extract method names, etc.Previously, all other Swift symbols (non-code), were being demangled into strings. However this appears unnecessary, skipping such Swift symbols has the following benefits:
In a trivial example, the number of log entries for demangling to strings went from 58682 to 0.