Skip to content

Overview.md: Correct path to sourcekit-lsp logs #2116

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Apr 23, 2025

Conversation

Wilfred
Copy link
Contributor

@Wilfred Wilfred commented Apr 18, 2025

This text was originally added in d8067fb, but as of 7d3b440 the log directory is now ~/.sourcekit-lsp.

This text was originally added in d8067fb, but as of 7d3b440 the log directory is now ~/.sourcekit-lsp.
@Wilfred Wilfred requested a review from ahoppen as a code owner April 18, 2025 00:20
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch and thank you!

@ahoppen
Copy link
Member

ahoppen commented Apr 18, 2025

@swift-ci Please test

@ahoppen ahoppen enabled auto-merge April 18, 2025 18:50
@Wilfred
Copy link
Contributor Author

Wilfred commented Apr 18, 2025

Incidentally, I also noticed that https://github.com/swiftlang/sourcekit-lsp/blob/main/Contributor%20Documentation/Environment%20Variables.md states that logs on Linux go to stderr, but it looks like that's no longer true as of #1286. It looks like logs go exclusively to ~/.sourcekit-lsp now.

@ahoppen how do you feel about logging to both stderr as well as a log file? Most LSP clients (e.g. VS Code, Emacs) make it easy for you to see stderr output as LSP servers usually write their logs there.

@ahoppen
Copy link
Member

ahoppen commented Apr 22, 2025

@swift-ci Please test Linux

@ahoppen
Copy link
Member

ahoppen commented Apr 22, 2025

@ahoppen how do you feel about logging to both stderr as well as a log file? Most LSP clients (e.g. VS Code, Emacs) make it easy for you to see stderr output as LSP servers usually write their logs there.

I think that’s reasonable. Would you like to create a PR to change it?

@ahoppen
Copy link
Member

ahoppen commented Apr 23, 2025

@swift-ci Please test Linux

@ahoppen ahoppen merged commit 9743e77 into swiftlang:main Apr 23, 2025
3 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants