Unify cache locations and pruning strategies #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
owenv
commented
Feb 10, 2025
owenv
commented
- Use the same cache path for all tools in the build.This is safe because it's versioned internally
- Wire up the cache pruning mechanism to generic task caching to ensure consistent behavior
- Improve test coverage of replay in incremental builds
- Use the same cache path for all tools in the build.This is safe because it's versioned internally - Wire up the cache pruning mechanism to generic task caching to ensure consistent behavior - Improve test coverage of replay in incremental builds
owenv
requested review from
jakepetroules,
mirza-garibovic,
mhrawdon and
neonichu
as code owners
|
@swift-ci test |
| let casPath = casOpts.casPath.str | ||
| let path = key.path.str | ||
|
|
||
| // Avoiding the swift concurrency variant because it may lead to starvation when `waitForCompletion()` |
There was a problem hiding this comment.
waitForCompletion() is async now, though
There was a problem hiding this comment.
I'm going to clean this up later alongside the other half of the pruning implementation
neonichu
approved these changes
Feb 11, 2025
jakepetroules
approved these changes
Feb 11, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.