Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[SWBCore] Enhance settings docs #155

Merged
merged 6 commits into from
Feb 13, 2025
Merged

[SWBCore] Enhance settings docs #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
95664c8
docs: fix the word `necessarily`
MojtabaHs Feb 13, 2025
9165172
docs: fix the word `architectures`
MojtabaHs Feb 13, 2025
fef2a81
docs: fix the word `successfully`
MojtabaHs Feb 13, 2025
4d5829d
docs: fix the word `overridden`
MojtabaHs Feb 13, 2025
5dd6620
docs: fix the word `arbitrary`
MojtabaHs Feb 13, 2025
9926201
docs: fix the word `terabytes`
MojtabaHs Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/SWBCore/Settings/CASOptions.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ public struct CASOptions: Hashable, Serializable, Encodable, Sendable {
return size * mb
case "G": // gigabytes
return size * gb
case "T": // terrabytes
case "T": // terabytes
return size * tb
default:
return nil
Expand Down
2 changes: 1 addition & 1 deletion Sources/SWBCore/Settings/RecursiveSearchPathResolver.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ public final class RecursiveSearchPathResolver: Sendable {

/// The maximum number of arguments to generate.
///
/// This is arbitary, and just to limit the traversal in corner cases.
/// This is arbitrary, and just to limit the traversal in corner cases.
public static let maximumNumberOfEntries = 1024

/// The file system the resolver uses.
Expand Down
10 changes: 5 additions & 5 deletions Sources/SWBCore/Settings/Settings.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1195,7 +1195,7 @@ private class SettingsBuilder {
/// The sparse SDKs to use.
let sparseSDKs: [SDK]

/// The SDK and platform values before they were overriden by the active run destination.
/// The SDK and platform values before they were overridden by the active run destination.
///
/// We use these to decide if we want to include the TOOLCHAINS from the SDK settings.
fileprivate let preOverrides: PreOverridesSettings
Expand Down Expand Up @@ -3316,7 +3316,7 @@ private class SettingsBuilder {
//
// The net result is the linker writes the actual path into the load command of the
// stub executor so it can be found at runtime, but the debug dylib has an actual
// identity as the specified client name. It therefore can succesfully link against
// identity as the specified client name. It therefore can successfully link against
// libraries with allowable client restrictions of the same name.
table.push(
BuiltinMacros.EXECUTABLE_DEBUG_DYLIB_INSTALL_NAME,
Expand Down Expand Up @@ -4071,8 +4071,8 @@ private class SettingsBuilder {
table.push(BuiltinMacros.ARCHS, literal: effectiveArchs.removingDuplicates())

// The set of Swift module-only architectures should be a set of valid architectures that's disjoint from the
// set of effective archtectures. We don't necessarily care about these architectures being deprecated as this
// setting will primarily be used to support building Swift modules for deprected (or at least unsupported)
// set of effective architectures. We don't necessarily care about these architectures being deprecated as this
// setting will primarily be used to support building Swift modules for deprecated (or at least unsupported)
// architectures.
let originalModuleOnlyArchs = scope.evaluate(BuiltinMacros.SWIFT_MODULE_ONLY_ARCHS)
let moduleOnlyArchs = onlyActiveArchApplied ? [] : originalModuleOnlyArchs
Expand Down Expand Up @@ -4824,7 +4824,7 @@ private class SettingsBuilder {
analyzeExcludedLocalizationFiles(inLevelWithTable: settings.table, scope: levelScope, name: settings.level, generalScope: scope)
}

// Diagnose unknown specialization options on targets. This is a warning and not an error so that if we introduce a new option, using it will not necesarily break compatibility with older Xcodes.
// Diagnose unknown specialization options on targets. This is a warning and not an error so that if we introduce a new option, using it will not necessarily break compatibility with older Xcodes.
if target != nil {
let unknownSpecializationOptions = Set(scope.evaluate(BuiltinMacros.SPECIALIZATION_SDK_OPTIONS)).subtracting(["internal"])
if !unknownSpecializationOptions.isEmpty {
Expand Down