-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: a typo in _OBSOLETE_MANUAL_BUILD_ORDER
everywhere
#156
Conversation
This is underscored and undocumented, it's not meant to be a public interface. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@swift-ci test
Can you please update the title and description of this PR to specify that it's a typo fix just like in your commit message? And do so for PRs going forward. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @mirza-garibovic on the title, but otherwise this looks good.
@swift-ci test |
_OBSOLETE_MANUAL_BUILD_ORDER
everywhere
_OBSOLETE_MANUAL_BUILD_ORDER
everywhere_OBSOLETE_MANUAL_BUILD_ORDER
everywhere
@mirza-garibovic thank you for the suggestion! Title has been updated as requested. I will try to reuse the PR title with the commit messages if they reflect similar changes. However, most of the time PRs include multiple changes with several commits (to facilitate easier reviews and any back-and-forth updates) and I need to summarizes the overall changes. I usually try to cover these in the summary, short and minimally:
If there are any guidelines to follow, please let me know. I would be happy to review them. |
@MojtabaHs thanks! Your thinking is good but summaries should be specific about the nature of the enhancement. |
I’ve resolved the issue throughout the codebase. However, since it involves a public property, it might be wise to introduce an alias using
@available
to enable automatic renaming.Let me know your thoughts.
Also, please remember to run the @swift-ci test.