Enable more windows test and fix some failing ones #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daveinglis
requested review from
jakepetroules,
mirza-garibovic,
mhrawdon,
neonichu and
owenv
as code owners
neonichu
reviewed
Feb 13, 2025
neonichu
approved these changes
Feb 13, 2025
owenv
approved these changes
Feb 13, 2025
|
@swift-ci test |
jakepetroules
requested changes
Feb 14, 2025
| commandLine: ["$(BUILD_DIR)/$(CONFIGURATION)/tool"], | ||
| environment: [:], | ||
| commandLine: ["$(BUILD_DIR)/$(CONFIGURATION)$(EFFECTIVE_PLATFORM_NAME)/tool\(runDestination == .windows ? ".exe" : "")"], | ||
| environment: ProcessInfo.processInfo.environment, |
There was a problem hiding this comment.
Why was this change needed?
There was a problem hiding this comment.
swift binaries need Path so they can find swiftCore.dll in swift runtime folder
|
@swift-ci test |
daveinglis
force-pushed
the
pr/test_updates
branch
from
331df12 to
8260339
Compare
|
@swift-ci test |
- fixed issue where a request to build a single output would fail on windows due to path separator differences used in llbuild manifest.
CustomTaskBuildOperationTest - fixes for windows
daveinglis
force-pushed
the
pr/test_updates
branch
from
8260339 to
f62723e
Compare
|
@swift-ci test |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most changes are to the tests except one change in Sources/SWBBuildSystem/BuildOperation.swift where the path used needed to have posix paths separators also some update to the Windows.xcspec file
(rdar://142882894)