rdar://143411533 (Object files and module wrap output end up in the same location, stomping on each other) #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakepetroules
approved these changes
Jan 31, 2025
owenv
approved these changes
Jan 31, 2025
…ame location, stomping on each other) On non macho-o platforms, swift-driver will create an additional module-wrap task if debugging is enabled which has an object file as output that will be named like the module and placed next to it. Since Swift Build will emit the Swift module next to the object files of a target, there can be a naming conflict, leading to us only ending up with the module-wrap content and the actual object file being stomped on. This introduces a new `PER_ARCH_MODULE_FILE_DIR` build setting that's the same as `PER_ARCH_OBJECT_FILE_DIR` by default that allows us to customize the output directory.
neonichu
force-pushed
the
bbuegling/143411533
branch
from
f030d6d to
1f0df01
Compare
neonichu
added a commit
that referenced
this pull request
Feb 4, 2025
I broke this in #31 since that added a new setting that needs to be manually applied in this particular test.
Merged
neonichu
added a commit
that referenced
this pull request
Feb 5, 2025
I broke these in #31 since that added a new setting that needs to be manually applied in this particular test.
neonichu
added a commit
that referenced
this pull request
Feb 6, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On non macho-o platforms, swift-driver will create an additional module-wrap task if debugging is enabled which has an object file as output that will be named like the module and placed next to it. Since Swift Build will emit the Swift module next to the object files of a target, there can be a naming conflict, leading to us only ending up with the module-wrap content and the actual object file being stomped on.
This introduces a new
PER_ARCH_MODULE_FILE_DIRbuild setting that's the same asPER_ARCH_OBJECT_FILE_DIRby default that allows us to customize the output directory.