Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[CI] Add basic entry point script #79

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

neonichu
Copy link
Collaborator

@neonichu neonichu commented Feb 3, 2025

This should allow us to control the specifics of CI testing from within the repo as needed.

This should allow us to control the specifics of CI testing from within the repo as needed.
@compnerd
Copy link
Member

compnerd commented Feb 3, 2025

This would be a problem for Windows. Can we use powershell instead?

@neonichu
Copy link
Collaborator Author

neonichu commented Feb 3, 2025

This would be a problem for Windows. Can we use powershell instead?

As far as I can tell, the current CI jobs on macOS/Linux are sh based, so I'm assuming Windows is anyway working differently on Swift CI?

@compnerd
Copy link
Member

compnerd commented Feb 3, 2025

Yes, but those are running full toolchain builds. Doing so here would roughly equate to ~4h runs per PR.

@jakepetroules
Copy link
Collaborator

@compnerd Do you mean add a powershell script in addition to the sh script? Not instead of?

@compnerd
Copy link
Member

compnerd commented Feb 4, 2025

@compnerd Do you mean add a powershell script in addition to the sh script? Not instead of?

Well, powershell is available on Linux, macOS, and windows and can therefore unify the CI script.

@dschaefer2
Copy link
Member

Most of the toolchain build is in Python, no?

@neonichu
Copy link
Collaborator Author

neonichu commented Feb 4, 2025

Most of the toolchain build is in Python, no?

Not used by the Windows build, AFAIK.

unify the CI script.

I think we should worry about unification once it is possible.

Right now, there's no Windows CI job at all on this repository and even once we add it, it'll have to use CMake in order to match the rest of the Windows build.

The purpose of this PR was just to pull a part of the existing CI jobs into the repo, nothing more. If we don't end up wanting that, I can close it, but I am not aiming for more right now.

Copy link
Collaborator

@jakepetroules jakepetroules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swift-ci please test macOS

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants