-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[CI] Add basic entry point script #79
base: main
Are you sure you want to change the base?
Conversation
This should allow us to control the specifics of CI testing from within the repo as needed.
This would be a problem for Windows. Can we use powershell instead? |
As far as I can tell, the current CI jobs on macOS/Linux are |
Yes, but those are running full toolchain builds. Doing so here would roughly equate to ~4h runs per PR. |
@compnerd Do you mean add a powershell script in addition to the sh script? Not instead of? |
Well, powershell is available on Linux, macOS, and windows and can therefore unify the CI script. |
Most of the toolchain build is in Python, no? |
Not used by the Windows build, AFAIK.
I think we should worry about unification once it is possible. Right now, there's no Windows CI job at all on this repository and even once we add it, it'll have to use CMake in order to match the rest of the Windows build. The purpose of this PR was just to pull a part of the existing CI jobs into the repo, nothing more. If we don't end up wanting that, I can close it, but I am not aiming for more right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@swift-ci please test macOS
This should allow us to control the specifics of CI testing from within the repo as needed.