Add locking primitives for TARGET_OS_WASI in CFLocking.h #2867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebAssembly/WASI doesn't support multi-threading yet, so these primitives don't do anything in this single-threaded environment, but allow the rest of the code using them to compile.
This comment has been minimized.
This comment has been minimized.
|
@swift-ci please test |
78 tasks
compnerd
approved these changes
Sep 6, 2020
There was a problem hiding this comment.
Seems reasonable to me; please wait for @millenomi to take a look as well.
|
@swift-ci please test and merge |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebAssembly/WASI doesn't support multi-threading yet (as reported in SR-12097), so these primitives don't do anything in this single-threaded environment, but allow the rest of the code using them to compile.