Skip to content

Disable file/dispatch-related code in Foundation for WASI #3050

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Sep 24, 2021

Conversation

MaxDesiatov
Copy link
Contributor

Functionality related to Dispatch, run loops, and full filesystem access (other than stdio/stderr file handles) is not available on WASI/Wasm. As a follow-up to previous Core Foundation PRs, this one updates parts of Foundation to add support for that platform.

@MaxDesiatov MaxDesiatov requested a review from millenomi August 16, 2021 14:46
@MaxDesiatov
Copy link
Contributor Author

@swift-ci please test

@MaxDesiatov
Copy link
Contributor Author

@swift-ci please test

@millenomi
Copy link
Contributor

Same comments here re: NSCoding.

@MaxDesiatov MaxDesiatov force-pushed the maxd/wasi-foundation branch 4 times, most recently from c7ae122 to 7a98383 Compare August 25, 2021 09:44
@MaxDesiatov
Copy link
Contributor Author

@swift-ci please test

@MaxDesiatov
Copy link
Contributor Author

@millenomi I've re-enabled NSCoding-related code here, it's ready for review

@MaxDesiatov MaxDesiatov force-pushed the maxd/wasi-foundation branch from 7a98383 to 4464ada Compare August 25, 2021 18:25
@MaxDesiatov
Copy link
Contributor Author

@swift-ci please test

@MaxDesiatov MaxDesiatov force-pushed the maxd/wasi-foundation branch 4 times, most recently from c54b739 to ed90316 Compare September 7, 2021 15:29
@MaxDesiatov
Copy link
Contributor Author

@swift-ci please test

@MaxDesiatov
Copy link
Contributor Author

@swift-ci please test macOS platform

@millenomi
Copy link
Contributor

@MaxDesiatov I'm looking tomorrow.

@AZero13
Copy link
Contributor

AZero13 commented Sep 21, 2021

@millenomi any updates?

@millenomi
Copy link
Contributor

Things slipped a little but I'm finally looking right now >.<'

@millenomi
Copy link
Contributor

I'm going to take it for right now, but I hope we can have follow-ups to re-expose write(to…) methods etc. to throw at runtime rather than be a hard compile error on use and force #if os(WASI) on clients. cc @MaxDesiatov

@millenomi millenomi merged commit ee856f1 into main Sep 24, 2021
@MaxDesiatov
Copy link
Contributor Author

That makes sense, thanks!

@MaxDesiatov MaxDesiatov deleted the maxd/wasi-foundation branch September 24, 2021 16:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants