-
Notifications
You must be signed in to change notification settings - Fork 204
[Gardening] Resolve deprecated API use warnings and remove stale code #1892
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: main
Are you sure you want to change the base?
Conversation
@swift-ci test |
1 similar comment
@swift-ci test |
@swift-ci test |
c58a5b6
to
c61b973
Compare
@swift-ci test |
@swift-ci test |
1 similar comment
@swift-ci test |
@swift-ci test |
c1cc289
to
f1bb300
Compare
@swift-ci test |
@swift-ci test Windows platform |
@swift-ci test |
@swift-ci test Windows platform |
@swift-ci test Linux platform |
@swift-ci test Windows platform |
This type is being deprecated and removed in 'swift-tools-support-core'. Move the implementation to the driver. Long term, the driver's executors should be re-architected to rely on structured concurrency primitives. In the meantime, absorb this functionality into the driver so that it can be freely removed from STSC.
@swift-ci test |
@swift-ci test Windows platform |
@@ -0,0 +1,131 @@ | |||
//===--------------- ProcessSet.swift - Swift Subprocesses ---------------===// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file/functionality is moved over from STSC where it is marked deprecated and I will follow-up this PR with removing it from STSC altogether. In the future, we should also deprecate this by moving to async Process
APIs or swift-subprocess
.
@swift-ci test Windows platform |
1 similar comment
@swift-ci test Windows platform |
ProcessEnv.vars
withProcessEnv.block
AbsolutePath
initializerProcessSet
implementation to the driverREADME.md
to remove stale content