Skip to content

[Gardening] Resolve deprecated API use warnings and remove stale code #1892

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented May 8, 2025

  • Deprecate old SwiftScan global scanner diagnostic queries. We have since moved on to per-scan queries and the approach being deprecated here is not safe.
  • Replace occurrences of the deprecated ProcessEnv.vars with ProcessEnv.block
  • Deprecate enablement of explicit modules with an environment variable
  • Resolve warnings about deprecated AbsolutePath initializer
  • Migrate ProcessSet implementation to the driver
  • Cleanup the README.md to remove stale content

@artemcm
Copy link
Contributor Author

artemcm commented May 8, 2025

@swift-ci test

1 similar comment
@artemcm
Copy link
Contributor Author

artemcm commented May 8, 2025

@swift-ci test

@artemcm
Copy link
Contributor Author

artemcm commented May 14, 2025

@swift-ci test

@artemcm artemcm force-pushed the GardenEBM branch 3 times, most recently from c58a5b6 to c61b973 Compare May 14, 2025 19:42
@artemcm
Copy link
Contributor Author

artemcm commented May 14, 2025

@swift-ci test

@artemcm
Copy link
Contributor Author

artemcm commented May 14, 2025

@swift-ci test

1 similar comment
@artemcm
Copy link
Contributor Author

artemcm commented May 30, 2025

@swift-ci test

@artemcm
Copy link
Contributor Author

artemcm commented Jun 10, 2025

@swift-ci test

@artemcm artemcm force-pushed the GardenEBM branch 2 times, most recently from c1cc289 to f1bb300 Compare June 13, 2025 17:37
@artemcm
Copy link
Contributor Author

artemcm commented Jun 13, 2025

@swift-ci test

@artemcm
Copy link
Contributor Author

artemcm commented Jun 13, 2025

@swift-ci test Windows platform

@artemcm
Copy link
Contributor Author

artemcm commented Jun 13, 2025

@swift-ci test

@artemcm
Copy link
Contributor Author

artemcm commented Jun 13, 2025

@swift-ci test Windows platform

@artemcm
Copy link
Contributor Author

artemcm commented Jun 16, 2025

@swift-ci test Linux platform

@artemcm
Copy link
Contributor Author

artemcm commented Jun 16, 2025

@swift-ci test Windows platform

This type is being deprecated and removed in 'swift-tools-support-core'. Move the implementation to the driver.
Long term, the driver's executors should be re-architected to rely on structured concurrency primitives. In the meantime, absorb this functionality into the driver so that it can be freely removed from STSC.
@artemcm
Copy link
Contributor Author

artemcm commented Jun 17, 2025

@swift-ci test

@artemcm
Copy link
Contributor Author

artemcm commented Jun 17, 2025

@swift-ci test Windows platform

@@ -0,0 +1,131 @@
//===--------------- ProcessSet.swift - Swift Subprocesses ---------------===//
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file/functionality is moved over from STSC where it is marked deprecated and I will follow-up this PR with removing it from STSC altogether. In the future, we should also deprecate this by moving to async Process APIs or swift-subprocess.

@artemcm
Copy link
Contributor Author

artemcm commented Jun 17, 2025

@swift-ci test Windows platform

1 similar comment
@artemcm
Copy link
Contributor Author

artemcm commented Jun 23, 2025

@swift-ci test Windows platform

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant