Skip to content

Fix typos in SE-0253. #1010

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 28, 2019
Merged

Fix typos in SE-0253. #1010

merged 6 commits into from
Mar 28, 2019

Conversation

dan-zheng
Copy link
Contributor

Remove duplicated text.

@dan-zheng
Copy link
Contributor Author

cc @rxwei @lattner

@rxwei
Copy link
Contributor

rxwei commented Mar 28, 2019

There's a bunch of non-ASCII "..."s. Can you fix those as well?

@dan-zheng
Copy link
Contributor Author

There's a bunch of non-ASCII "..."s. Can you fix those as well?

Done.

@rxwei
Copy link
Contributor

rxwei commented Mar 28, 2019

Also make a link on line 7 with text "swiftlang/swift#23517".

@dan-zheng
Copy link
Contributor Author

Also make a link on line 7 with text "apple/swift#23517".

Done.

rxwei
rxwei reviewed Mar 28, 2019
View reviewed changes
@rxwei @dan-zheng
Use ASCII quotes.
71f5ed7 
Co-Authored-By: dan-zheng <danielzheng@google.com>
@lattner lattner merged commit 8987fee into swiftlang:master Mar 28, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@rxwei rxwei rxwei left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dan-zheng @rxwei @lattner