Skip to content

Add tweaks for Android #618

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Dec 18, 2022
Merged

Add tweaks for Android #618

merged 1 commit into from
Dec 18, 2022

Conversation

finagolfin
Copy link
Member

This pull gets this repo to build and pass all the tests natively on my Android AArch64 phone.

@finagolfin
Copy link
Member Author

@Azoy, would you review?

Copy link
Contributor

@Azoy Azoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, thanks!

@Azoy
Copy link
Contributor

Azoy commented Dec 15, 2022

@swift-ci please test

@finagolfin
Copy link
Member Author

MacOS CI is broken, other pulls fail with the same error.

@natecook1000
Copy link
Member

Sorry about that! CI is fixed now.

@swift-ci Please test

@finagolfin
Copy link
Member Author

Can someone merge? Would be nice to have this in the 5.8 branch tomorrow.

@Azoy Azoy merged commit 3ca8b13 into swiftlang:main Dec 18, 2022
@finagolfin finagolfin deleted the droid branch December 19, 2022 05:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants