Rename _InstructionCounter
#632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the unified build there ends up being two of these, one in swift-syntax and one in swift-format. Rename so that the target is unique.
bnbarham
force-pushed
the
unified-pm-broken
branch
from
1f2549b to
481e155
Compare
glessard
approved these changes
Sep 18, 2023
|
I'm not really sure why cross PR testing didn't catch this 🤔 |
|
Doesn't the |
|
It does :( |
This was referenced Sep 19, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the unified build there ends up being two of these, one in swift-syntax and one in swift-format. Rename so that the target is unique.