Import new Bionic module from Android overlay instead where possible #7755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finagolfin
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis and
xedin
as code owners
compnerd
reviewed
Jul 4, 2024
| @@ -19,6 +19,8 @@ import Musl | |||
| #elseif os(Windows) | |||
| import CRT | |||
| import WinSDK | |||
| #elseif canImport(Android) | |||
| import Android | |||
There was a problem hiding this comment.
Can we use Bionic here instead? Note that Darwin is using Darwin.C and Windows is using CRT. Of course if we need more than the C interfaces, Android is fine, but would be nice to keep this scoped to the same level as the other platforms.
There was a problem hiding this comment.
I'll check if that's enough.
Also, add the import in `Environment.swift` too
finagolfin
changed the title
compnerd
approved these changes
Jul 8, 2024
|
@rauhul, a CI run and we can get this in. |
|
@swift-ci please test |
|
@kateinoigakukun, passed CI, ready for merge. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, add the import in
Environment.swifttoo@rauhul, you added that last file just after I got these imports in with #7615, so I recently had to add this too to keep it building on Android.