Skip to content

Fixup several classes of warnings #8361

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2025
Merged

Fixup several classes of warnings #8361

merged 1 commit into from
Mar 19, 2025

Conversation

plemarquand
Copy link
Contributor

@plemarquand plemarquand commented Mar 11, 2025 •
edited
Loading

  • Remove now-redundant Sendable conformances
  • Remove unused variables
  • Fix a few missed unnecessary @retroactive conformances
  • Use swiftlang/swift-llbuild.git instead of apple/swift-llbuild.git

@jakepetroules
Copy link
Contributor

@swift-ci test

@plemarquand plemarquand force-pushed the fix-more-warnings branch 8 times, most recently from 86313d6 to 970e775 Compare March 14, 2025 14:15
@plemarquand
Copy link
Contributor Author

@swift-ci test

@plemarquand
Copy link
Contributor Author

@swift-ci test windows

@bkhouri bkhouri mentioned this pull request Mar 18, 2025
Merged
bkhouri
bkhouri approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@bkhouri bkhouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though there were a couple of @_implementationOnly that were not converted to internal

@plemarquand
Fixup several classes of warnings
d9886c1 
- Remove now-redundant Sendable conformances
- Remove unused variables
- Fix a few missed unnecessary @retroactive conformances
- Use swiftlang/swift-llbuild.git instead of apple/swift-llbuild.git
@plemarquand
Copy link
Contributor Author

@swift-ci please test

@plemarquand
Copy link
Contributor Author

@swift-ci please test windows

@plemarquand
Copy link
Contributor Author

@swift-ci please test linux

@plemarquand
Copy link
Contributor Author

@swift-ci test windows

@bkhouri bkhouri mentioned this pull request Mar 19, 2025
Closed
cmcgee1024
cmcgee1024 approved these changes Mar 19, 2025
View reviewed changes
Copy link
Member

@cmcgee1024 cmcgee1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning all of these things up.

@plemarquand plemarquand merged commit c6874d3 into swiftlang:main Mar 19, 2025
5 checks passed
@plemarquand plemarquand deleted the fix-more-warnings branch March 19, 2025 16:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jakepetroules jakepetroules jakepetroules approved these changes

@bkhouri bkhouri bkhouri approved these changes

@cmcgee1024 cmcgee1024 cmcgee1024 approved these changes

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

@MaxDesiatov MaxDesiatov Awaiting requested review from MaxDesiatov MaxDesiatov is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

@dschaefer2 dschaefer2 Awaiting requested review from dschaefer2 dschaefer2 is a code owner

@shawnhyam shawnhyam Awaiting requested review from shawnhyam shawnhyam is a code owner

@bripeticca bripeticca Awaiting requested review from bripeticca bripeticca is a code owner

@owenv owenv Awaiting requested review from owenv owenv is a code owner

@daveyc123 daveyc123 Awaiting requested review from daveyc123 daveyc123 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@plemarquand @jakepetroules @bkhouri @cmcgee1024