Skip to content

[Macros] Introduce macro specification in assertMacroExpansion #2327

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

soumyamahunt
Copy link
Contributor

Resolves #2031.

Implements fixes suggested by @DougGregor.

Allows testing extension macros completely.

Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for tackling this issue @soumyamahunt!

@soumyamahunt soumyamahunt force-pushed the extension-macro-assert-fix branch from 773c715 to 49ab6cc Compare November 27, 2023 07:38
@soumyamahunt soumyamahunt force-pushed the extension-macro-assert-fix branch from 49ab6cc to 8a5c581 Compare December 28, 2023 07:55
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏🏽 Looks very good. I just have a few comments on the documentation.

Also: Could you add an entry fro this in the 511.md release notes?

Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ahoppen
Copy link
Member

ahoppen commented Jan 10, 2024

@swift-ci Please test

Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solution looks really nice, thank you!

@ahoppen
Copy link
Member

ahoppen commented Feb 6, 2024

Looks like this has a few merge conflicts now. Could you resolve them @soumyamahunt?

@soumyamahunt soumyamahunt force-pushed the extension-macro-assert-fix branch from f18828c to 577366a Compare February 6, 2024 05:04
@soumyamahunt
Copy link
Contributor Author

@ahoppen resolved conflicts

@ahoppen ahoppen enabled auto-merge February 6, 2024 05:07
@ahoppen
Copy link
Member

ahoppen commented Feb 6, 2024

@swift-ci Please test

Copy link
Contributor

@Matejkob Matejkob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about squashing commits?

@ahoppen
Copy link
Member

ahoppen commented Feb 6, 2024

Looks like the documentation contains a few invalid references now. Could you resolve them by making sure that ./swift-syntax-dev-utils verify-documentation passes?

And squashing commits would also be appreciated.

auto-merge was automatically disabled February 7, 2024 19:41

Head branch was pushed to by a user without write access

@soumyamahunt soumyamahunt force-pushed the extension-macro-assert-fix branch from 577366a to 8001ce8 Compare February 7, 2024 19:41
@soumyamahunt soumyamahunt changed the title [Macros] Introduce conformsTo in assertMacroExpansion [Macros] Introduce macro specification in assertMacroExpansion Feb 7, 2024
@soumyamahunt
Copy link
Contributor Author

@ahoppen documentation links are fixed and commits squashed

Allows testing extension and member macros conformances
@ahoppen ahoppen force-pushed the extension-macro-assert-fix branch from 8001ce8 to b866edb Compare February 9, 2024 22:58
@ahoppen
Copy link
Member

ahoppen commented Feb 9, 2024

Thank you. There was a merge conflict in the release notes now. I took the liberty to fix it and force-push to your branch.

@ahoppen
Copy link
Member

ahoppen commented Feb 9, 2024

@swift-ci Please test

@ahoppen ahoppen enabled auto-merge February 9, 2024 22:59
@ahoppen
Copy link
Member

ahoppen commented Feb 13, 2024

@swift-ci Please test Windows

@ahoppen ahoppen merged commit 5d5beb9 into swiftlang:main Feb 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

assertMacroExpansion always passes empty array as conformingTo parameter of extension macros
5 participants