Add basic platform support for Android. #653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR seeks out all the nooks and crannies where we have platform-specific code or logic and adds Android. In most cases, it's as simple as changing `os(Linux)` to `os(Linux) || os(Android)` but there are a few spots where they diverge. The PR should be _mostly_ self-explanatory. Co-authored by: Saleem Abdulrasool <compnerd@compnerd.org>
grynspan
added
enhancement
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci test |
compnerd
approved these changes
Aug 29, 2024
|
Would be great if you can confirm this builds and (ideally) runs before I merge it. I am not set up to verify it on Android at this time. |
|
@finagolfin We could use your input as well! |
|
I've never built this repo for Android, in part because it didn't have any snapshot tags till a couple days ago, so don't know anything about it. If and when I do build it, I'll chime in then. |
|
We'll go ahead and move forward with this PR—if you run into issues, please let us know and we can open subsequent PRs to resolve them. (Waiting for core team review as well.) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR seeks out all the nooks and crannies where we have platform-specific code or logic and adds Android. In most cases, it's as simple as changing
os(Linux)toos(Linux) || os(Android)but there are a few spots where they diverge. The PR should be mostly self-explanatory.Checklist:
Co-authored-by: Saleem Abdulrasool compnerd@compnerd.org