Remove #expect(throws: Never.self) and #require(throws: Never.self) as distinct overloads.
#661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)` as distinct overloads. `#expect(throws: Never.self)` and `#require(throws: Never.self)` do not need to be specified as separate overloads. This PR removes them as distinct symbols: - The documentation for `#expect(throws: Never.self)` is merged into the documentation for `#expect(throws:)`. - The diagnostic emitted when using `#require(throws: Never.self)` is lowered from a deprecation warning to a macro-generated custom warning. This change has no other compile-time or runtime effects: code that passes `Never.self` to either macro will continue to compile, and macros cannot be referenced so there is no risk of source-level breakage like there might be from a function signature change.
grynspan
added
documentation
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci test |
stmontgomery
approved these changes
Sep 4, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#expect(throws: Never.self)and#require(throws: Never.self)do not need to be specified as separate overloads. This PR removes them as distinct symbols:#expect(throws: Never.self)is merged into the documentation for#expect(throws:).#require(throws: Never.self)is lowered from a deprecation warning to a macro-generated custom warning.This change has no other compile-time or runtime effects: code that passes
Never.selfto either macro will continue to compile, and macros cannot be referenced so there is no risk of source-level breakage like there might be from a function signature change.Checklist: