Skip to content

Revert "Replace rethrows with typed throws in Graph" #679

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Sep 11, 2024

Reverts #662

This change is likely the culprit for crashes on the CI bot:
Swift Incremental RA - macOS - Apple Silicon

@artemcm
Copy link
Contributor Author

artemcm commented Sep 11, 2024

@swift-ci test

@grynspan
Copy link
Contributor

Please hold for review from Stuart. :)

@grynspan grynspan added bug 🪲 Something isn't working workaround Workaround for an issue in another component (may need to revert later) build 🧱 Affects the project's build configuration or process labels Sep 11, 2024
@grynspan grynspan added this to the Swift 6.1 milestone Sep 11, 2024
@grynspan
Copy link
Contributor

Also @aschwaighofer is working on a proper compiler fix, I believe?

Copy link
Contributor

@stmontgomery stmontgomery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Once a compiler fix PR is posted, I'd appreciate if someone could mention it here for visibility so we can follow up and un-revert this

@stmontgomery stmontgomery merged commit 70f173e into main Sep 11, 2024
3 checks passed
@stmontgomery stmontgomery deleted the revert-662-graph-typed-throws branch September 11, 2024 15:45
@stmontgomery
Copy link
Contributor

For tracking purposes: We believe the Swift compiler change which conflicted with the changes in this PR was reverted here: swiftlang/swift#76435

stmontgomery added a commit that referenced this pull request Sep 16, 2024
This un-reverts the changes originally landed in #662. Those changes
were reverted in #679 due to a compiler issue which broke CI builds. We
believe that compiler issue has been resolved via a revert in the Swift
repo, made in swiftlang/swift#76435.

Before landing this (currently draft) PR, I plan to validate that
Swift's CI is no longer affected using a cross-repo CI toolchain build.

### Checklist:

- [x] Code and documentation should follow the style of the [Style
Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md).
- [x] If public symbols are renamed or modified, DocC references should
be updated.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug 🪲 Something isn't working build 🧱 Affects the project's build configuration or process workaround Workaround for an issue in another component (may need to revert later)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants