Skip to content

[android] fix the build #681

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2024
Merged

[android] fix the build #681

merged 1 commit into from
Sep 11, 2024

Conversation

hyp
Copy link
Contributor

@hyp hyp commented Sep 11, 2024

the posix_filesystem module is available only from Swift, as it comes from the Swift android overlay.

Motivation:

Fixing the android build.

Modifications:

Modify include.

Result:

It builds.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@hyp
Copy link
Contributor Author

hyp commented Sep 11, 2024

@swift-ci please test

@hyp hyp requested a review from compnerd September 11, 2024 18:48
grynspan
grynspan requested changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@grynspan grynspan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicks.

@hyp
[android] fix the build
36a10c5 
the posix_filesystem module is available only from Swift, as it comes from the Swift android overlay
@hyp hyp force-pushed the eng/android-build-fix branch from 430e6b6 to 36a10c5 Compare September 11, 2024 19:36
@hyp
Copy link
Contributor Author

hyp commented Sep 11, 2024

@swift-ci please test

@grynspan grynspan added this to the Swift 6.1 milestone Sep 11, 2024
@grynspan grynspan added bug 🪲 Something isn't working android 🤖 Android support labels Sep 11, 2024
@hyp hyp merged commit 9fbfe54 into main Sep 11, 2024
3 checks passed
@hyp hyp deleted the eng/android-build-fix branch September 11, 2024 20:35
@grynspan
Copy link
Contributor

@hyp Note if you need this fix in Swift 6.0.1, please clone the PR and nominate it using the procedure outlined here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@stmontgomery stmontgomery stmontgomery approved these changes

@compnerd compnerd compnerd approved these changes

@grynspan grynspan grynspan approved these changes

@dennisweissmann dennisweissmann Awaiting requested review from dennisweissmann

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski SeanROlszewski is a code owner

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

Assignees

@hyp hyp

Labels
android 🤖 Android support bug 🪲 Something isn't working
Projects
None yet
Milestone
Swift 6.1
Development

Successfully merging this pull request may close these issues.
4 participants
@hyp @grynspan @stmontgomery @compnerd