Skip to content

Disable pipes code on WASI. #699

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 17, 2024
Merged

Disable pipes code on WASI. #699

merged 2 commits into from
Sep 17, 2024

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Sep 17, 2024 •
edited
Loading

WASI does not support pipes.

Resolves #698.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan
Disable pipes code on WASI.
58981a8 
WASI does not support pipes.

Resolves #698.
@grynspan grynspan added bug 🪲 Something isn't working wasi/wasm 🧭 WebAssembly support labels Sep 17, 2024
@grynspan grynspan self-assigned this Sep 17, 2024
@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan
Copy link
Contributor Author

@kateinoigakukun Please assist testing this PR. Thanks!

@grynspan
Copy link
Contributor Author

@swift-ci test

@kateinoigakukun
Copy link
Member

I verified it builds well on WASI, thanks for your quick fix!

@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan grynspan merged commit 9693475 into main Sep 17, 2024
0 of 3 checks passed
@grynspan grynspan deleted the jgrynspan/698-wasi-no-pipes branch September 17, 2024 03:40
@grynspan
Copy link
Contributor Author

Thaaaat wasn't the auto-merge button.

Oh well.

@kateinoigakukun kateinoigakukun mentioned this pull request Sep 17, 2024
Merged
grynspan added a commit that referenced this pull request Sep 17, 2024
@grynspan
Disable pipes code on WASI. (#699)
324f6b8 
WASI does not support pipes.

Resolves #698.

### Checklist:

- [x] Code and documentation should follow the style of the [Style
Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md).
- [x] If public symbols are renamed or modified, DocC references should
be updated.
@grynspan grynspan added this to the Swift 6.1 milestone Sep 17, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kateinoigakukun kateinoigakukun kateinoigakukun approved these changes

@stmontgomery stmontgomery Awaiting requested review from stmontgomery stmontgomery is a code owner

@dennisweissmann dennisweissmann Awaiting requested review from dennisweissmann

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski SeanROlszewski is a code owner

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

Assignees

@grynspan grynspan

Labels
bug 🪲 Something isn't working wasi/wasm 🧭 WebAssembly support
Projects
None yet
Milestone
Swift 6.1
Development

Successfully merging this pull request may close these issues.

Conditionalize pipe(2) usage for WASI
2 participants
@grynspan @kateinoigakukun