Reset default signal handlers on child processes before spawning them. #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grynspan
added
bug
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci test |
stmontgomery
approved these changes
Sep 26, 2024
On platforms that use `posix_spawn()`, we should take care to reset the signal
handlers of child processes to their defaults, right? Or should this be valid?
```swift
signal(SIGABRT, SIG_IGN)
await #expect(exitsWith: .success) {
raise(SIGABRT) // does nothing because we set it to SIG_IGN in the parent
exit(0)
}
```
grynspan
force-pushed
the
jgrynspan/set-sigdef
branch
from
adce4d6 to
62371bb
Compare
|
@swift-ci test |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On platforms that use
posix_spawn(), we should take care to reset the signal handlers of child processes to their defaults, right? Or should this be valid?Checklist: