Skip to content

Fix a test that fails to compile on 32-bit targets. #753

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2024
Merged

Fix a test that fails to compile on 32-bit targets. #753

merged 1 commit into from
Oct 7, 2024

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Oct 7, 2024 •
edited
Loading

An expression in testCollectionDifferenceSkippedForRanges() overflows on 32-bit targets like watchOS. This fixes that.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan
Fix a test that fails to compile on 32-bit targets.
fcc9df2 
An expression in `testCollectionDifferenceSkippedForRanges()` overflows on
32-bit targets like watchOS. This fixes that.
@grynspan grynspan added the bug 🪲 Something isn't working label Oct 7, 2024
@grynspan grynspan self-assigned this Oct 7, 2024
@grynspan
Copy link
Contributor Author

grynspan commented Oct 7, 2024

@swift-ci test

@grynspan grynspan added this to the Swift 6.1 milestone Oct 7, 2024
@grynspan grynspan merged commit 619b4a9 into main Oct 7, 2024
3 checks passed
@grynspan grynspan deleted the jgrynspan/fix-failing-32bit-test branch October 7, 2024 21:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@stmontgomery stmontgomery stmontgomery approved these changes

@briancroom briancroom briancroom approved these changes

@dennisweissmann dennisweissmann Awaiting requested review from dennisweissmann

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski SeanROlszewski is a code owner

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

Assignees

@grynspan grynspan

Labels
bug 🪲 Something isn't working
Projects
None yet
Milestone
Swift 6.1
Development

Successfully merging this pull request may close these issues.
3 participants
@grynspan @stmontgomery @briancroom